Logical operators #100
Merged
Logical operators #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
I translated line 7 as it was but in my opinion to keep it readable it would be better this way: نتیجه 0 || 1- برابر با 1- است، truthy Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
I translated line 7 as it was but in my opinion to keep it readable it would be better this way: نتیجه 0 || 1- برابر با 1- است، truthy Please review and comment / commit if anything is wrong
Translation is not done yet
I translated line 100 as it was but I think it would be better this way: این باعث چند استفاده جالب نسبت به یک "OR خالص و کلاسیک که تنها boolean قبول می کند" می شود. Please let me know what you think
Translation is not done yet
I translated line 100 as it was but I think it would be better this way: این باعث چند استفاده جالب نسبت به یک "OR خالص و کلاسیک که تنها boolean قبول می کند" می شود. Please let me know what you think and review and comment / commit if anything is wrong
mahdyar
requested changes
Mar 26, 2021
| @@ -1,4 +1,4 @@ | |||
| The answer is `2`, that's the first truthy value. | |||
| جواب 2 است، آن(2) اولین مقدار truthy است. | |||
There was a problem hiding this comment.
The 2 should be between backquotes:
جواب `2` است
and there is no need to mention it again:
آن(2)
|
|
||
| ## || (OR) | ||
| ## || (OR یا) |
There was a problem hiding this comment.
There is no need for Persian translation.
Comment on lines
24
to
27
| alert( true || true ); // true درست | ||
| alert( false || true ); // true درست | ||
| alert( true || false ); // true درست | ||
| alert( false || false ); // false اشتباه |
There was a problem hiding this comment.
Use either true or درست, not both of them.
Use either false or اشتباه, not both of them.
| alert( Boolean(null) ); // false | ||
| ``` | ||
|
|
||
| The precedence of NOT `!` is the highest of all logical operators, so it always executes first, before `&&` or `||`. | ||
| اولویت NOT `!` بالاترین اولویت بین عملگر های منطقی دارد، بنابراین همیشه اول اجرا می شود، قبل از `&&` یا `||`. |
There was a problem hiding this comment.
The sentence readability could be better:
عملگر NOT `!` بالاترین اولویت را بین عملگرهای منطقی دارد،
|
|
||
| ```js run | ||
| let hour = 12; | ||
| let isWeekend = true; | ||
|
|
||
| if (hour < 10 || hour > 18 || isWeekend) { | ||
| alert( 'The office is closed.' ); // it is the weekend | ||
| alert( 'The office is closed.' ); // آخر هفته است |
There was a problem hiding this comment.
The office is closed. should also be translated.
|
Please make the requested changes. After it, add a comment "/done". |
All the mentioned problems are fixed.
|
Thank you for your review, @mahdyar |
|
/done |
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the description of article.md and solution.md of task 8 "if question".
Please review and comment / commit if anything is wrong